Something I’ve noticed a lot with PRs is that someone attempts to close a ticket, and when we see their implementation we jump on it with tons of requests and nits (Yes, I am on both ends of this).
To cut back on wasted developer work, tickets that are feature requests should have a section called Acceptance Criteria. This section should detail everything that needs to be present/absent/tested for the ticket to be closed. These could be very specific technical features or they could be broader UX or architectural statements. They could also detail tests necessary to ensure the new feature works correctly or not including edge cases.
We should update the password hashing mechanism to use
I want to use a lib that handles multiple hashing algorithms so I don’t have to write boilerplate code.
- There is a database migration that adds the new pw hash columns to the database
- There are tests for users created only using the old pw hash mechanism to ensure they can still log in
- Once a user has logged in using the new mechanism, the old pw_hash column is cleared